Repository navigation
Satisfy clippy 1.98 - #164
Merged
Merged
Conversation
Rust 1.98 promotes three lints that fail the warning-free build. ModelError carried a Usage inline, and Usage's provider cost decimals put the whole error over the size bound clippy enforces for Err variants that most provider-facing results return; the usage moves behind a Box, keeping every public signature and accessor unchanged. The two single-element range vectors build through an explicit one-element iterator, which states the intent the lint exists to question. The hex pair walk uses the stabilized as_chunks.
Contributor
Author
|
@postil review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI resolves the stable toolchain at run time, and Rust 1.98 brings three clippy lints that fail the warning-free build for every branch, including
main.ModelErrorcarried aUsageinline, and the provider cost decimals inUsageput the error over the size bound clippy enforces onErrvariants; the usage moves behind aBox, leaving every public signature and accessor unchanged. The two single-element range vectors build through an explicit one-element iterator, and the hex pair walk uses the stabilizedas_chunks.