Repository navigation
Prepare Luna scoring for hosted reviews - #167
Merged
Merged
Conversation
There was a problem hiding this comment.
2 blocking findings open
1 finding posted inline · 1 finding in review details
- Correct the stale scorer-chain claim in pull request description: The description incorrectly says hosted reviews use generator self-confidence with an empty scorer chain. Update it to reflect that Luna is now enabled as both the generator and scorer, while qualification still requires the managed benchmark and attestation.
There was a problem hiding this comment.
2 blocking findings open
1 finding posted inline
1 suppressed
- Correct the stale scorer-chain claim at
.postil/pr-description:2: deterministically non-actionable; severity error, confidence 0.98. The description incorrectly says hosted reviews use generator self-confidence with an empty scorer chain. Update it to reflect that Luna is now enabled as both the generator and scorer, while qualification still requires the managed benchmark and attestation.
Before the next push
Run postil review --staged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hosted confidence needs a separate scorer rather than generator self-assessment. This enables Luna as both the generator and a separate scorer call, teaches admission validation to price a model shared across roles without allowing duplicate fallback entries, and keeps the qualification manifest empty so release authority still requires the exact-source managed benchmark and attestation.