Skip to content

Make low-signal fixture hunks realistic #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morgaesis merged 1 commit into from
Jul 10, 2026
Merged

Make low-signal fixture hunks realistic #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions bench/fixtures/cases.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1019,12 +1019,12 @@ const fixtureSpecs: FixtureSpec[] = [
after: "await applyBulkEdit(changeSet);",
hunks: [
{ line: 6, before: "const title = 'Bulk edit';", after: "const title = 'Bulk edit ';"},
{ line: 18, before: "const batchSize = 50;", after: "const batchSize = 50;"},
{ line: 18, before: "const batchSize=50;", after: "const batchSize = 50;"},
{ line: 33, before: "logger.debug('bulk edit start');", after: "logger.debug('bulk edit started');"},
{ line: 57, before: "const summary = buildSummary(changeSet);", after: "const summary = buildSummary(changeSet);"},
{ line: 57, before: "const summary = buildSummary(changeSet);", after: "const editSummary = buildSummary(changeSet);"},
{ line: 88, before: "if (!actor.can('bulkEdit')) throw new Error('Forbidden');", after: "await applyBulkEdit(changeSet);"},
{ line: 122, before: "return { ok: true, summary };", after: "return { ok: true, summary };"},
{ line: 147, before: "metrics.increment('bulk_edit.done');", after: "metrics.increment('bulk_edit.done');"},
{ line: 122, before: "return { ok: true, summary };", after: "return { ok: true, summary: editSummary };"},
{ line: 147, before: "metrics.increment('bulk_edit.done');", after: "metrics.increment('bulk_edit.completed');"},
],
allowedFileContent:
"export async function bulkEdit(actor: Actor, changeSet: ChangeSet) { await applyBulkEdit(changeSet); }",
Expand All @@ -1047,11 +1047,11 @@ const fixtureSpecs: FixtureSpec[] = [
after: "timeoutMs: 0,",
hunks: [
{ line: 9, before: "const userAgent = 'postil/1';", after: "const userAgent = 'postil/1 ';"},
{ line: 21, before: "headers.set('accept', 'application/json');", after: "headers.set('accept', 'application/json');"},
{ line: 43, before: "const retry = retryPolicy.standard();", after: "const retry = retryPolicy.standard();"},
{ line: 64, before: "metrics.increment('provider.request');", after: "metrics.increment('provider.request');"},
{ line: 21, before: "headers.set('accept', 'application/json');", after: "headers.set('accept', 'application/vnd.api+json');"},
{ line: 43, before: "const retry = retryPolicy.standard();", after: "const retryPolicyForProvider = retryPolicy.standard();"},
{ line: 64, before: "metrics.increment('provider.request');", after: "metrics.increment('provider.requests');"},
{ line: 96, before: "timeoutMs: 5_000,", after: "timeoutMs: 0,"},
{ line: 118, before: "return parseProviderResponse(response);", after: "return parseProviderResponse(response);"},
{ line: 118, before: "return parseProviderResponse(response);", after: "return parseResponse(response);"},
],
allowedFileContent:
"export const providerClient = createClient({ timeoutMs: 0, retry: retryPolicy.standard() });",
Expand Down
26 changes: 13 additions & 13 deletions bench/src/harness.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,19 +37,19 @@ describe("benchmark fixtures", () => {
expect(hunkCount).toBeGreaterThan(1);
}

const clean = hugeCases.find((c) => c.id === "huge-low-signal-clean");
expect(clean).toBeDefined();
const removed = clean!.diff
.split("\n")
.filter((line) => line.startsWith("- "))
.map((line) => line.slice(2));
const added = clean!.diff
.split("\n")
.filter((line) => line.startsWith("+ "))
.map((line) => line.slice(2));
expect(removed.length).toBeGreaterThan(1);
expect(added.length).toBe(removed.length);
expect(added.some((line, index) => line !== removed[index])).toBe(true);
for (const c of hugeCases) {
const removed = c.diff
.split("\n")
.filter((line) => line.startsWith("- "))
.map((line) => line.slice(2));
const added = c.diff
.split("\n")
.filter((line) => line.startsWith("+ "))
.map((line) => line.slice(2));
expect(removed.length).toBeGreaterThan(1);
expect(added.length).toBe(removed.length);
expect(added.every((line, index) => line !== removed[index])).toBe(true);
}
});
});

Expand Down
Loading