Repository navigation
Add blockOnKinds gate predicate and finding IDs - #46
Merged
Merged
postil-dev / postil/review
succeeded
Jul 11, 2026 in 53s
1 error, 0 warn, 0 info
The finding ID generation has a delimiter-less prehash key that causes collisions when path and line boundaries align, making IDs unstable and breaking duplicate tracking.
error
src/review.rs:391— Prehash key collision in finding ID generation · confidence 0.95 · kind: risk
Model: moonshotai/kimi-k2.6
Annotations
Check failure on line 391 in src/review.rs
postil-dev / postil/review
Prehash key collision in finding ID generation
The `prehash_key` used for duplicate counting concatenates `head_sha`, kind, path, and line without
delimiters. This causes collisions when path and line boundaries align (e.g., path `"foo1"` + line
`"2"` produces the same key as path `"foo"` + line `"12"`). Collisions assign incorrect duplicate
indices, making finding IDs unstable across runs and breaking deduplication/approval tracking. Fix:
insert a delimiter (e.g., `\x00`) between fields in the `prehash_key` format string, matching the
`hash_input` delimiter pattern.
Loading