Repository navigation
Activate default LLM timeout budget - #50
Conversation
There was a problem hiding this comment.
The default LLM total timeout is now always active, including for local runs, which may unexpectedly break long-running local reviews that previously had no total timeout.
warn
src/llm.rs:195— Default total timeout now applies to local runs · confidence 0.90 · kind: humanEscalation
Model: deepseek/deepseek-v4-pro
37d9585 to
7eab70f
Compare
There was a problem hiding this comment.
The README incorrectly states that every review (local or hosted) is subject to a default 540-second total timeout, but the code applies that default only to hosted runs; local reviews have no total timeout unless the environment variable is set. This false claim could mislead users.
error
README.md:201— README falsely claims default total timeout applies to local reviews · confidence 0.90 · kind: contentPolicywarn
src/llm.rs:195— Default total timeout now applies to local runs · confidence 0.90 · kind: humanEscalation
Model: deepseek/deepseek-v4-pro
There was a problem hiding this comment.
The default per-request LLM timeout was reduced from 480s to 420s, which may cause timeouts for large diffs in local runs where no total budget is active. This change is not mentioned in the PR description and could be an unintended regression.
warn
src/llm.rs:144— Default per-request LLM timeout reduced from 480s to 420s · confidence 0.70 · kind: humanEscalationerror
README.md:201— README falsely claims default total timeout applies to local reviews · confidence 0.90 · kind: contentPolicywarn
src/llm.rs:195— Default total timeout now applies to local runs · confidence 0.90 · kind: humanEscalation
Model: deepseek/deepseek-v4-pro
There was a problem hiding this comment.
The change reduces DEFAULT_REQUEST_TIMEOUT_SECS from 480 to 420 seconds for all execution modes. This may cause previously passing long-running local/CI reviews to time out. Confirm this is intentional.
warn
src/llm.rs:144— Default request timeout quietly reduced from 480 to 420 · confidence 0.80 · kind: riskerror
README.md:201— README falsely claims default total timeout applies to local reviews · confidence 0.90 · kind: contentPolicywarn
src/llm.rs:195— Default total timeout now applies to local runs · confidence 0.90 · kind: humanEscalation
Model: deepseek/deepseek-v4-pro
c050ed8 to
d6e3dd6
Compare
d6e3dd6 to
7854d36
Compare
…dates the current commit's actual content)
There was a problem hiding this comment.
The per-request timeout default had dropped from 480s to 420s universally, including for local/interactive runs that have no total budget to fit within -- 420s only makes sense for the hosted path (540s total - 120s scorer). Threads a request-timeout default through from_env_for_remote_review alongside the existing total-timeout default, matching the split already used for the total budget: local keeps 480s, hosted uses 420s explicitly via HOSTED_LLM_REQUEST_TIMEOUT_SECS.
The comment claimed the 420s value came from '4 models * 120s', which doesn't match the actual constant or its real derivation (540s total minus the 120s scorer reserve = 420s).
Adds a default total LLM request budget so hosted reviews stay inside the worker's outer watchdog even when no environment variable overrides it: 540 seconds total, reserving 120 seconds for the independent scorer and leaving a 60-second margin before the 600-second watchdog fires. Local and interactive runs are unaffected by default and keep no total budget unless POSTIL_LLM_TOTAL_TIMEOUT_SECS is explicitly set. Crate version bumped to 0.4.2, with new regression tests for the default budget and for a cascade retry expiring mid-request.