Skip to content

Fix review comment formatting and add humanEscalation confidence floor - #53

Merged
morgaesis merged 1 commit into
mainfrom
feat/comment-ux
Jul 12, 2026
Merged

morgaesis merged 1 commit into
mainfrom
feat/comment-ux

Conversation

@morgaesis

Copy link
Copy Markdown
Contributor

Fixes review comment generation issues identified in PR feedback. Removes redundant file:line location prefixes from top-level comment summaries (already shown in GitHub's inline comments), wraps review metadata in a foldable <details> section with commit SHA link and Postil dashboard run URL, and makes gate pass/fail outcomes explicit and unambiguous.

Implements a 0.30 confidence floor for humanEscalation findings to prevent weak boilerplate findings from blocking gates while preserving visibility. Findings below the floor still surface with clear indication they do not block.

  • Redundant location prefixes removed; severity/confidence/kind shown without path:line
  • Gate outcome (pass/fail) stated clearly at top of summary
  • Review metadata in foldable section: duration, commit link, dashboard URL, token usage, scorer info
  • Confidence floor for humanEscalation: 0.30 minimum to block gates
  • All forge backends (GitHub, GitLab, Bitbucket, Azure) use consistent new SummaryContext
  • Gate logic refactored to dedicated finding_blocks_gate() for semantic consistency
  • 170 tests passing (Rust cargo test)

Addresses PR comment formatting gaps by removing redundant path:line prefixes from top-level summaries (already shown in inline comments), wrapping review metadata in a foldable <details> section with commit link and dashboard run URL, and making gate outcomes (pass/fail) explicit and unambiguous.

Implements a 0.30 confidence floor for humanEscalation-kind findings to prevent weak boilerplate findings from blocking gates while preserving visibility for human review. The confidence floor is documented in code and tested. Findings below the floor still appear in summaries with a note indicating they do not block.

All backends (GitHub, GitLab, Bitbucket, Azure) updated to use the new SummaryContext for consistent behavior. Gate logic refactored into a dedicated finding_blocks_gate() function to ensure live reviews, envelope replay, and forge summaries share identical blocking semantics.
@morgaesis
morgaesis merged commit 1ce4734 into main Jul 12, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant