Repository navigation
Externalize model cascade configuration - #54
Merged
Merged
Conversation
Move hardcoded DEFAULT_MODEL, DEFAULT_CASCADE, DEFAULT_SCORER_MODEL, and DEFAULT_SCORER_FALLBACK from src/config.rs into config.toml at the project root. Use include_str!() with OnceLock for one-time lazy parsing. Add comprehensive tests verifying parsed values match the file and malformed files fail loudly. Fix README.md to correctly state local default timeout is 480 seconds.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move hardcoded model defaults from src/config.rs into config.toml at the project root, embedded via include_str!() with OnceLock for lazy parsing. Add tests verifying parsed values match the file and malformed files fail loudly. Fix README.md to correctly state local DEFAULT_REQUEST_TIMEOUT_SECS is 480 seconds, not 420 (which is hosted-only).