This repository was archived by the owner on Nov 9, 2021. It is now read-only.
Template modification to simplify applying styles#79
Open
nladuguie wants to merge 1 commit intopoteto:masterfrom
Open
Template modification to simplify applying styles#79nladuguie wants to merge 1 commit intopoteto:masterfrom
nladuguie wants to merge 1 commit intopoteto:masterfrom
Conversation
Add a span around a non linked breadcrumb entry to easily apply a style
Collaborator
|
@nladuguie could you please rebase this against |
dguettler
reviewed
Oct 17, 2016
| {{else}} | ||
| {{route.title}} | ||
| {{/if}} | ||
| <span> |
Collaborator
There was a problem hiding this comment.
I don't think the <span> should wrap the yield as it would prevent you from using any other elements.
Maybe consider it as a default for the case where the is no block given?
dguettler
suggested changes
Oct 17, 2016
Collaborator
dguettler
left a comment
dguettler
left a comment
There was a problem hiding this comment.
See comments above regarding usage of span
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a span around a non linked breadcrumb entry to easily apply a style