This repository was archived by the owner on Nov 9, 2021. It is now read-only.
Changes for a more flexible Component#86
Open
jakubikan wants to merge 6 commits intopoteto:masterfrom
Open
Conversation
changed the test in order to work with that change
…ther its the last object or not
Collaborator
|
☔ The latest upstream changes (presumably #91) made this pull request unmergeable. Please resolve the merge conflicts. |
# Conflicts: # .travis.yml # addon/components/bread-crumbs.js
Author
|
I merged every thing and also, the test should also pass now also with the new code styling validations |
Collaborator
|
@jakubikan I'll review your changes as soon as possible |
Collaborator
|
☔ The latest upstream changes (presumably #111) made this pull request unmergeable. Please resolve the merge conflicts. |
Collaborator
|
This breaks backwards compatibility in multiple places. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to generalize this component to have it more flexible I made some changes.
I removed the filters (for index and loading) and the Breadcrumb Classes.
Other then that I changed the breadcrumb behavior a bit so you need to define a
breadCrumbobject in order to have a breadcrumb at this route. (if nothing is defined it will not show anything)I also added the routeHierarchy to the block of the
bread-crumbscomponent, so you can check inside the block whether its the last/first routeObject.I hope that's in your favor.