Skip to content

transforms deleted docs if handleDeleted: true (rebased) - #26

Open
nolanlawson wants to merge 3 commits into
masterfrom
21-rebased
Open

transforms deleted docs if handleDeleted: true (rebased)#26
nolanlawson wants to merge 3 commits into
masterfrom
21-rebased

Conversation

@nolanlawson

Copy link
Copy Markdown
Member

rebased version of #21

@nolanlawson

Copy link
Copy Markdown
Member Author

@gr2m I tried to re-rebase this, but looks like it has some merge conflicts. Could you take a look when you get a chance?

@gr2m

gr2m commented Apr 14, 2016

Copy link
Copy Markdown
Collaborator

could you add me as contributor to transform-pouch?

@nolanlawson

Copy link
Copy Markdown
Member Author

whoops sorry, I should have done that awhile ago. I'll also publish a new release in a bit

@nolanlawson

Copy link
Copy Markdown
Member Author

Also note that I just pushed some more commits that I had forgotten to merge from various PRs... lots of commits to merge!

@gr2m

gr2m commented Apr 14, 2016

Copy link
Copy Markdown
Collaborator

I got it :) Thanks

@nolanlawson

Copy link
Copy Markdown
Member Author

1.1.0 published with all the latest changes; this feature can go in a 1.2.0 once it's passing. :)

@gr2m

gr2m commented Apr 14, 2016

Copy link
Copy Markdown
Collaborator

I think we don’t need it anymore, do we? #20 & #21 were both solutions for #18. And #20 was merged via #25, so this PR becomes obsolete as it’s a rebased version of #21. The handleDeleted option is no longer necessary, it checks if the removed document has custom properties and if it does, it gets transformed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants