This repository was archived by the owner on Jan 28, 2021. It is now read-only.
Fix NPE in auto-disenchanter when it breaks an item with enchants remaining#335
Open
pantheis wants to merge 1 commit into
Open
Fix NPE in auto-disenchanter when it breaks an item with enchants remaining#335pantheis wants to merge 1 commit into
pantheis wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you try to auto-disenchant an item with low durability with multiple enchants in repeat mode and the item breaks before removing all enchants, the current code will NPE on the server. This fixes that issue.