Improve tab close detection for shared sync worker#425
Open
simolus3 wants to merge 4 commits into
Open
Conversation
Contributor
|
I found the following issue which I am not sure if it's a regression: Launch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, sync workers detect closed tabs by listening on
database.closedfor a database backed bysqlite3_web(which internally uses navigator locks to detect closed tabs).This kind of works, but can lead to deadlocks when a tab is closed while it's serving a request (like a
fetchCredentialsorrequestDatabasecall) that would never complete.To improve reliability, this adopts the usual navigator locks pattern to our
WorkerCommunicationChannelas well:I've also added a small test for the shared sync worker in
sync_worker_test.dart. It emulates a shared worker by manually passing ports from aMessageChannelto it. I've also tested this in a demo app (and actually found an issue insqlite3_web, I'll fix that too).