The second multithreading task#2
Open
ppapou wants to merge 2 commits into
Open
Conversation
ppapou
commented
Aug 10, 2023
ppapou
commented
Owner
- file scanner has added
added 2 commits
August 10, 2023 17:17
- file scanner has added
oleksandr-ilin
approved these changes
Aug 14, 2023
oleksandr-ilin
left a comment
oleksandr-ilin
left a comment
There was a problem hiding this comment.
generally it is good
But have just few minor recommendations. See my review comments.
| /** | ||
| * Current processed file | ||
| */ | ||
| protected final File mFile; |
There was a problem hiding this comment.
Why do you define the members as protected
Also I would recommend to avoid Hungarian notation in Java.
Also that is bad practice according to Clean Code principles.
Instead try to give is a good and meaningful name consists from normal English words.
| * Directories count | ||
| */ | ||
| protected final AtomicLong mFolderCount; | ||
| FileCounterTask(File file, AtomicLong mDocumentCount, AtomicLong mFolderCount) { |
There was a problem hiding this comment.
Why the constructor has package visibility?
How would you like to use this class?
| } | ||
|
|
||
| @Override | ||
| protected Long compute() { |
There was a problem hiding this comment.
This method deserve to be split up on smaller logical chunks. So you can clearly see the logical structure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.