Relax fqmul output bound to 5/4*Q#1131
Draft
hanno-becker wants to merge 1 commit into
Draft
Conversation
Contributor
CBMC Results (ML-DSA-44)
Full Results (200 proofs)
|
Contributor
CBMC Results (ML-DSA-87, REDUCE-RAM)
Full Results (200 proofs)
|
Contributor
CBMC Results (ML-DSA-87)
Full Results (200 proofs)
|
Contributor
CBMC Results (ML-DSA-65, REDUCE-RAM)
Full Results (200 proofs)
|
Contributor
CBMC Results (ML-DSA-44, REDUCE-RAM)
Full Results (200 proofs)
|
Contributor
CBMC Results (ML-DSA-65)
Full Results (200 proofs)
|
5e3cedf to
fdb5926
Compare
This commit relaxes the output bound for modular multiplication from MLDSA_Q to 5/4 * MLDSA_Q. This bound is attained when using a Barrett multiplication based on MUL+MULH+MLS rather than MUL+SQRDMULH+MLS. For now, mldsa-native does not contain any code which requires the weaker output bound, but this commit gives us flexibility to add it in the future if we need it. For example, a RV32-IM backend would likely use a MUL+MULH+MLS based Barrett multiplication which is subject to the 5/4 * MLDSA_Q bound. Signed-off-by: Hanno Becker <beckphan@amazon.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit relaxes the output bound for modular multiplication
from MLDSA_Q to 5/4 * MLDSA_Q. This bound is attained when using
a Barrett multiplication based on MUL+MULH+MLS rather than
MUL+SQRDMULH+MLS.
For now, mldsa-native does not contain any code which requires
the weaker output bound, but this commit gives us flexibility to
add it in the future if we need it. For example, a RV32-IM backend
would likely use a MUL+MULH+MLS based Barrett multiplication which
is subject to the 5/4 * MLDSA_Q bound.