-
Notifications
You must be signed in to change notification settings - Fork 13
codex -> agent skills #257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,238 @@ | ||
| --- | ||
| name: creating-agent-skills | ||
| description: Use when creating Agent Skills packages (SKILL.md format) for Codex CLI, GitHub Copilot, or Amp - provides the agentskills.io specification with frontmatter constraints, directory structure, and validation rules | ||
| --- | ||
|
|
||
| # Creating Agent Skills | ||
|
|
||
| ## Overview | ||
|
|
||
| Agent Skills is an open standard for portable AI agent capabilities. One SKILL.md file works across Codex CLI, GitHub Copilot, and Amp. | ||
|
|
||
| **Official Spec:** https://agentskills.io/specification | ||
|
|
||
| ## Installation Directories | ||
|
|
||
| | Tool | Location | | ||
| |------|----------| | ||
| | **Codex CLI** | `.agents/skills/{skill-name}/SKILL.md` | | ||
| | **GitHub Copilot** | `.github/skills/{skill-name}/SKILL.md` | | ||
| | **Amp** | `.agents/skills/{skill-name}/SKILL.md` | | ||
|
|
||
| ## Directory Structure | ||
|
|
||
| ``` | ||
| my-skill/ # Must match frontmatter `name` | ||
| ├── SKILL.md # Required - main definition | ||
| ├── scripts/ # Optional - executable code | ||
| ├── references/ # Optional - additional docs | ||
| └── assets/ # Optional - static resources | ||
| ``` | ||
|
|
||
| ## Frontmatter Specification | ||
|
|
||
| ### Required Fields | ||
|
|
||
| ```yaml | ||
| --- | ||
| name: skill-name | ||
| description: What it does and when to use it | ||
| --- | ||
| ``` | ||
|
|
||
| | Field | Constraints | | ||
| |-------|-------------| | ||
| | `name` | 1-64 chars, lowercase alphanumeric + hyphens, no leading/trailing/consecutive hyphens, must match parent directory | | ||
| | `description` | 1-1024 chars, explains functionality AND use cases | | ||
|
|
||
| ### Optional Fields | ||
|
|
||
| ```yaml | ||
| --- | ||
| name: pdf-processing | ||
| description: Extracts and processes PDF content. Use for document analysis and text extraction. | ||
| license: MIT | ||
| compatibility: Requires pdftotext, poppler-utils | ||
| allowed-tools: Bash(pdftotext:*) Read Write | ||
| metadata: | ||
| category: document-processing | ||
| version: 1.0.0 | ||
| --- | ||
| ``` | ||
|
|
||
| | Field | Constraints | | ||
| |-------|-------------| | ||
| | `license` | Short reference (e.g., `MIT`, `Apache-2.0`) | | ||
| | `compatibility` | 1-500 chars, environment requirements | | ||
| | `allowed-tools` | Space-delimited pre-approved tools (experimental) | | ||
| | `metadata` | Arbitrary string key-value pairs | | ||
|
|
||
| ## Name Validation | ||
|
|
||
| ``` | ||
| ✅ Valid: pdf-processing, code-review, data-analysis | ||
| ❌ Invalid: PDF-Processing (uppercase), -pdf (leading hyphen), pdf--processing (consecutive hyphens) | ||
| ``` | ||
|
|
||
| **Pattern:** `^[a-z0-9]+(-[a-z0-9]+)*$` | ||
|
|
||
| ## Description Best Practices | ||
|
|
||
| ```yaml | ||
| # ❌ BAD - Too vague | ||
| description: Helps with PDFs | ||
|
|
||
| # ❌ BAD - Missing use cases | ||
| description: Extracts text from PDFs | ||
|
|
||
| # ✅ GOOD - Functionality + use cases | ||
| description: Extracts and processes PDF content. Use for document analysis, text extraction, and form data parsing. | ||
| ``` | ||
|
|
||
| **Include:** | ||
| - What the skill does | ||
| - When to activate it (keywords agents search for) | ||
| - Specific use cases | ||
|
|
||
| ## Body Content | ||
|
|
||
| Markdown instructions after frontmatter. No format restrictions, but recommended sections: | ||
|
|
||
| ```markdown | ||
| --- | ||
| name: code-review | ||
| description: Reviews code for best practices and security issues. Use when analyzing PRs or conducting audits. | ||
| --- | ||
|
|
||
| ## Overview | ||
| Brief description of capabilities. | ||
|
|
||
| ## Process | ||
| 1. Step-by-step workflow | ||
| 2. With clear actions | ||
|
|
||
| ## Guidelines | ||
| - Bullet points for rules | ||
| - Best practices | ||
|
|
||
| ## Examples | ||
| Code samples showing usage. | ||
| ``` | ||
|
|
||
| ## Progressive Disclosure | ||
|
|
||
| Skills use tiered loading to optimize context: | ||
|
|
||
| 1. **Metadata** (~100 tokens): `name` + `description` load at startup | ||
| 2. **Activation** (<5000 tokens): Full `SKILL.md` loads when selected | ||
| 3. **On-demand**: Supporting files load when referenced | ||
|
|
||
| **Keep `SKILL.md` under 500 lines** for efficient context usage. | ||
|
|
||
| ## Supporting Files | ||
|
|
||
| ### scripts/ | ||
| Executable code agents can invoke: | ||
| ```python | ||
| #!/usr/bin/env python3 | ||
| # scripts/extract.py | ||
| import sys | ||
| # Self-contained with clear dependencies | ||
| ``` | ||
|
|
||
| ### references/ | ||
| Additional documentation: | ||
| - `REFERENCE.md` - Technical details | ||
| - `FORMS.md` - Templates | ||
| - Domain-specific files | ||
|
|
||
| ### assets/ | ||
| Static resources: templates, diagrams, lookup tables. | ||
|
|
||
| **Reference with relative paths:** `scripts/extract.py`, `references/REFERENCE.md` | ||
|
|
||
| ## Complete Example | ||
|
|
||
| ```markdown | ||
| --- | ||
| name: typescript-expert | ||
| description: Expert TypeScript assistance with strict typing and modern patterns. Use for TypeScript projects requiring type safety, generics, or advanced type manipulation. | ||
| license: MIT | ||
| compatibility: Requires Node.js 18+, TypeScript 5+ | ||
| --- | ||
|
|
||
| You are an expert TypeScript developer. | ||
|
|
||
| ## Guidelines | ||
|
|
||
| - Always use strict type checking | ||
| - Prefer `unknown` over `any` | ||
| - Use type guards for runtime checking | ||
| - Leverage template literal types | ||
|
|
||
| ## Best Practices | ||
|
|
||
| - Export types from dedicated `.types.ts` files | ||
| - Use `readonly` for immutable data | ||
| - Prefer interfaces for objects, types for unions | ||
|
|
||
| ## Examples | ||
|
|
||
| ### Type Guard | ||
|
|
||
| ```typescript | ||
| function isUser(obj: unknown): obj is User { | ||
| return ( | ||
| typeof obj === 'object' && | ||
| obj !== null && | ||
| 'id' in obj && | ||
| 'name' in obj | ||
| ); | ||
| } | ||
| ``` | ||
| ``` | ||
|
|
||
| ## Validation | ||
|
|
||
| Use the validation tool: | ||
| ```bash | ||
| skills-ref validate ./my-skill | ||
| ``` | ||
|
|
||
| Checks: | ||
| - YAML frontmatter validity | ||
| - Name format compliance | ||
| - Required fields presence | ||
| - Directory name matches `name` field | ||
|
|
||
| ## Quick Checklist | ||
|
|
||
| **Frontmatter:** | ||
| - [ ] `name` is 1-64 chars, lowercase alphanumeric + hyphens | ||
| - [ ] `name` matches parent directory name | ||
| - [ ] `description` is 1-1024 chars | ||
| - [ ] `description` includes functionality AND use cases | ||
|
|
||
| **Content:** | ||
| - [ ] Under 500 lines for efficient loading | ||
| - [ ] Clear instructions agents can follow | ||
| - [ ] Examples for complex operations | ||
|
|
||
| **Structure:** | ||
| - [ ] Directory named exactly as `name` field | ||
| - [ ] `SKILL.md` at directory root | ||
| - [ ] Supporting files in appropriate subdirectories | ||
|
|
||
| ## Cross-Tool Compatibility | ||
|
|
||
| The SKILL.md format is identical across implementations. To port: | ||
|
|
||
| ```bash | ||
| # Codex → Copilot | ||
| mv .agents/skills/my-skill .github/skills/my-skill | ||
|
|
||
| # Copilot → Codex/Amp | ||
| mv .github/skills/my-skill .agents/skills/my-skill | ||
| ``` | ||
|
|
||
| No content changes required. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -163,9 +163,13 @@ function getDefaultPath(format: string, filename: string, subtype?: string, cust | |
| case 'droid': | ||
| return join(process.cwd(), '.factory', `${baseName}.md`); | ||
| case 'codex': | ||
| // Codex skills go to .codex/skills/{name}/SKILL.md | ||
| // Codex skills go to .agents/skills/{name}/SKILL.md | ||
| if (subtype === 'skill') { | ||
| return join(process.cwd(), '.codex', 'skills', baseName, 'SKILL.md'); | ||
| return join(process.cwd(), '.agents', 'skills', baseName, 'SKILL.md'); | ||
| } | ||
| // Codex agents go to .agents/agents/{name}/AGENT.md | ||
| if (subtype === 'agent') { | ||
| return join(process.cwd(), '.agents', 'agents', baseName, 'AGENT.md'); | ||
| } | ||
| // Other subtypes use AGENTS.md | ||
| return join(process.cwd(), 'AGENTS.md'); | ||
|
|
@@ -217,8 +221,11 @@ function detectFormat(content: string, filepath: string): string | null { | |
| if (filepath.includes('.zed/extensions') || filepath.includes('.zed/slash_commands')) { | ||
| return 'zed'; | ||
| } | ||
| if (filepath.includes('.codex/skills')) { | ||
| return 'codex'; | ||
| if (filepath.includes('.agents/skills')) { | ||
| return 'codex-skill'; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P2: detectFormat now returns "codex-skill"/"codex-agent", but handleConvert only supports "codex". This makes .agents/skills or .agents/agents files fail conversion with "Unsupported source format". Add cases for the new formats or map them back to "codex" before the switch. Prompt for AI agents |
||
| } | ||
| if (filepath.includes('.agents/agents')) { | ||
| return 'codex-agent'; | ||
| } | ||
|
|
||
| // Use robust content detection from converters | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: Codex slash commands currently fall through to the generic AGENTS.md path, but the Agent Skills/Codex docs specify that progressive-disclosure slash commands should live at
.opencommands/{name}.md. This mislocation means converted Codex slash commands won't be written where the editor expects them, so they may not be discovered or invoked correctly as slash commands. Add a dedicatedslash-commandbranch in the CodexgetDefaultPathcase to target.opencommands/{name}.md. [logic error]Severity Level: Major⚠️
Steps of Reproduction ✅
Prompt for AI Agent 🤖