fix --as codex for skill#261
Conversation
|
CodeAnt AI is reviewing your PR. Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
codeant-ai
Bot
added
the
size:L
Sequence DiagramThis PR adds a tools override option to install and ensures Claude skill metadata is preserved when converting to Codex skill format. The main flow shows how install propagates the override into conversion and writes the final skill file. sequenceDiagram
participant User
participant CLI
participant Install
participant Converter
participant FileSystem
User->>CLI: Run install with target format and tools override
CLI->>Install: Call handle install with tools option
Install->>Install: Download package and parse source skill
alt Target is Codex skill
Install->>Converter: Convert to Codex with allowed tools override
Converter-->>Install: Return SKILL content with preserved frontmatter
else Target is Claude
Install->>Install: Apply Claude tools override in frontmatter
end
Install->>FileSystem: Save updated skill file
Install-->>User: Report install success
Generated by CodeAnt AI |
🤖 My Senior Dev — Analysis Complete👤 For @khaliqgant📁 Expert in View your contributor analytics → 📊 6 files reviewed • 3 high risk • 5 need attention 🚨 High Risk:
🚀 Open Interactive Review →The full interface unlocks features not available in GitHub:
💬 Chat here: 📖 View all 12 personas & slash commandsYou can interact with me by mentioning In PR comments or on any line of code:
Slash commands:
AI Personas (mention to get their perspective):
For the best experience, view this PR on myseniordev.com — includes AI chat, file annotations, and interactive reviews. |
Nitpicks 🔍
|
![codeant-ai[bot]](https://avatars.githubusercontent.com/in/646884?s=60&v=4){kind=small}
|
CodeAnt AI finished reviewing your PR. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
2 issues found across 6 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/cli/src/commands/install.ts">
<violation number="1" location="packages/cli/src/commands/install.ts:1276">
P2: The Codex `--tools` override only runs for single-file installs, so multi-file skills keep the old `allowed-tools` value.</violation>
<violation number="2" location="packages/cli/src/commands/install.ts:2010">
P2: `--tools` is not forwarded when `install` runs from `prpm.lock`, so the new flag is silently ignored for no-package installs.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
- Normalize space-separated tools to comma-separated for Claude format (e.g. 'Read Write' → 'Read, Write') in both conversion and native install paths - Apply Codex --tools override to SKILL.md in multi-file packages (previously only worked for single-file installs) - Warn when --tools is passed with bare 'prpm install' (lockfile mode) since per-install overrides don't apply to lockfile reinstalls
|
CodeAnt AI is running Incremental review Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
codeant-ai
Bot
added
size:L
There was a problem hiding this comment.
1 issue found across 1 file (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/cli/src/commands/install.ts">
<violation number="1" location="packages/cli/src/commands/install.ts:150">
P1: Splitting Claude tools on whitespace corrupts valid Bash restrictions like `Bash(git add:*)`.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
|
CodeAnt AI Incremental review completed. |
Tools like Bash(git add:*) contain spaces inside parens — naive whitespace splitting corrupted them. Now uses regex to match tool tokens with optional parenthesized args.
There was a problem hiding this comment.
1 issue found across 1 file (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/cli/src/commands/install.ts">
<violation number="1" location="packages/cli/src/commands/install.ts:152">
P2: `--tools` values that mix commas and spaces are normalized incorrectly for Claude, merging adjacent tools into one entry.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
1 participant
CodeAnt-AI Description
Preserve skill frontmatter and allow --tools overrides when converting or installing Claude skills
What Changed
Impact
✅ Clearer skill frontmatter after conversion✅ Consistent allowed-tools in installed and converted skills✅ Fewer mismatched tool lists for multi-file Codex packages💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.