Mini QA on some WebControls - #1244
Merged
Merged
Conversation
belisoful
marked this pull request as ready for review
August 26, 2026 06:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The agents suggested that TButton and TLinkButton needed to pass a parameter along to OnClick. I didn't want to look at it because it might indicate a bigger change. I looked.
The change was suggested because the param was not typed properly. This was traced in the system. A documentation clean up was in order for a few things. I did not look at a larger scope because Prado in general needs an agent to do a documentation validation pass.
During its validation of TButton and TLinkButton, it found that TActiveDialog and ActiveDetails were in fact missing.
While not a documentation change, it is part of the QA that was done to ensure quality.