TInPlaceDropDownList, TInPlaceControlTrait; updates TInPlaceTextBox - #1248
Merged
Conversation
…erties. TInPlaceTextBox - deprecates AutoHideTextBox for AutoHideEditor; deprecates DisplayTextBox for DisplayEditor
…t for select based InPlace controls. TInPlaceDropDownList - changed to use TInPlaceListControlTrait
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In-place list controls: TInPlaceDropDownList & TInPlaceListBox
Closes #702. Adds the in-place drop down list requested in the issue, plus a
multi-select list box, refactors the in-place family onto shared traits, and
makes the whole family keyboard- and screen-reader-accessible.
New controls (
@since 4.4.0)TInPlaceDropDownList(TActiveDropDownList) — click/keyboard-to-editlabel over a hidden
<select>; commits on change;OnLoadingItemsevent.TInPlaceListBox(TActiveListBox) — multi-select; selection accumulatesand commits on blur; label joins selected texts with
SelectionSeparator.Refactor
TInPlaceControlTrait(label/edit-trigger/EmptyDisplayText/AutoHideEditor/DisplayEditor) andTInPlaceListControlTrait(select-basedsurface).
TInPlaceTextBoxand both new controls compose them; the drop downdropped 265→66 lines.
inlineeditor.jsrewritten aroundPrado.WebUI.TInPlaceControlBasewithTInPlaceTextBox/TInPlaceDropDownList/TInPlaceListBoxsubclasses.TInPlaceTextBox additions
EmptyDisplayText(family-wide; keeps an empty label clickable,data-prado-emptymarker so the placeholder is never read back as a value).
TTextBoxModeset (Date/Number/Email/Color/…).AutoHideTextBox/DisplayTextBoxkept as deprecated aliases of the family names.Prado.htmlEncode()toprado.js.Accessibility
role="button"tabindex="0"witharia-live="polite";Enter/Space edit; focus returns to the label after Enter/Esc/commit (not on
tab-away). Read-only ⇒ plain text. Editor
aria-labelfromToolTip.Tests
including a keyboard-accessibility end-to-end test. Full suite green (only the
pre-existing MySQL/PostgreSQL env failures remain).
Backward compatibility
Additive and BC. No visual change unless the app opts into focus styling.