Upgrades JS CallbackControl.onPostback - better logging on exception - #1253
Merged
Conversation
belisoful
marked this pull request as ready for review
August 30, 2026 05:54
Member
Author
|
The Agents identified that if there is an exception, that "preventDefault" is not called and falls back to posting the page. Any exception is written to the JS log as a matter of the browser function... but it would immediately be erased by the post response. Any intrinsically logged exceptions are unknown and unrecoverable. This PR makes the logging of the exception deliberate and known. The agents recommended rearranging the order of operation, but after considering the pros and cons, the way it is works but needs better exception handling. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Callback dispatch: log on failure, fall back to the default action
CallbackControl.onPostBack(andTActiveImageButton) previously calleddispatch()thenpreventDefault(). Ifdispatch()threw — typically from aClientSidehook —preventDefault()never ran, so the failure was silent and the click still fell through to a postback.Now the dispatch is wrapped: on throw, the error is logged via
Logger.errorand rethrown, andpreventDefault()is deliberately skipped so a submit button degrades to a full-page postback instead of dead-ending.TActiveImageButtonkeeps its x/y coordinate inputs on failure so the fallback submit carries the click position.JS-only; no PHP change. Adds unit coverage in
activecontrols.test.jsand a functional spec (TActiveButtonPostBackFallbackTestCase).