[codex] Keep Vertex streams open during idle periods#2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the local Vertex proxy streaming path so long Vertex responses do not get cut off during idle periods.
Changes:
Why
Hermes saw
RemoteProtocolError/ incomplete chunked reads when the proxy hit an upstreamhttpx.ReadTimeoutmid-stream. That closed the response abruptly and made the client see a broken chunked response instead of a clean model error.Validation
.venv/bin/pytest -q-> 20 passed.venv/bin/ruff check .git diff --checkcurl -fsS http://127.0.0.1:8787/health-> healthy against projectluminik-459117Operational note
The local launchd service was restarted and is currently healthy on
127.0.0.1:8787.