docs: fix streaming/auth/scope accuracy and scrub em-dashes#4
Merged
Conversation
- README: streaming is supported on the OpenAI-compat route too, not just Anthropic and Gemini; drop the stale "~400 lines" figure. - CONTRIBUTING: optional bearer-token auth (VERTEX_PROXY_API_KEY) exists, so the "intentionally does not authenticate" note was wrong; remove the reference to a tests/integration/ dir that does not exist. - Scrub remaining em-dashes from README, CONTRIBUTING, the systemd example, and a code comment for consistency with the project's prose style.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small docs/accuracy pass found while reviewing the repo after #3.
Corrections
_stream_bytespath, and there's a streaming test on/openai/v1/chat/completions), not just Anthropic and Gemini. Also dropped the stale "~400 lines" figure (the package is now ~900 lines after streaming/metrics/auth/Docker additions).VERTEX_PROXY_API_KEY); reworded to reflect it's off by default but available. Also removed a reference to atests/integration/directory that does not exist.Style
No code or behavior changes. Suite: 22 passed, ruff check + format clean.