Conversation
Update joss branch
…t comment #45. Cleaned README.md in tools and mentions that the scripts are outdated. Updated README.md to refer to pixi file
… (noble). README includes details of building library using ubuntu docker
JOSS review: Address #45
* Separate tasks out in Pixi manifest to allow for running build, testing, and install tasks separately. Add canonical 'start' task to build and install software. Add 'test' task that will do a clean build and run ctests. * Update task name from 'build' to 'test' in README. * Remove 'rm' of build directory from 'build' task to allow for potentially skipping files that do not need to be regenerated and to give user slightly more control.
* To fully use some tools in the environment, allow for Pixi to locally execute post-link shell scripts defined by project dependencies. - c.f. https://pixi.sh/dev/reference/pixi_configuration/#run-post-link-scripts
ENH: Add 'start' and additional tasks to Pixi manifest
JOSS paper edits
Joss final draft
add joss paper details
Integrate JOSS paper assets, Pixi/CI/README, cmake package config, and tools from main while keeping modular geometry/mesh layout (src/geom, MeshGen, createParticlesFromFile). Conflict resolution: - Per-target CMake: modular library names (Geom, Mesh, MeshGen, Fracture) + install include dirs - demModel: keep modular particle-from-file path (main used legacy util::geometry API) - geomObjects.cpp/util: keep modular src/geom; drop duplicate util/geomObjects.h - Root install(EXPORT): Geometry -> Geom; list Mesh, MeshGen, Fracture - fmt: not linked until external/fmt is populated; commented fmt install rule - MeshGen: BUILD_INTERFACE/INSTALL_INTERFACE for export-safe includes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Proposed Changes
Any background context you want to provide?