Fix Discord token auto-auth fallback - #10
Draft
ZARAEM wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
beforeunload, which matches Discord's token flush behavior used by the bundled Classic extension.localStoragesurface is unavailable.Root cause
Extension auto-auth only checked direct page
localStorage, so Discord changes that keep or expose the token differently could leave Discrub unable to retrieve a token even while the user is logged into discord.com.Fixes #9.
Validation
npm test -- src/extension/content.test.ts src/extension/tokenExtraction.test.tsnpm test -- src/extension/background.test.ts src/extension/messaging.test.ts src/extension/integration.test.tsnpm run build:extension:chromenpm run build:extension:firefoxnpm run build