feat(filter): improve store filter init, scoping, and shared constants#646
Open
leseb wants to merge 2 commits into
Open
feat(filter): improve store filter init, scoping, and shared constants#646leseb wants to merge 2 commits into
leseb wants to merge 2 commits into
Conversation
leseb
requested review from
franciscojavierarceo,
shaneutt and
twghu
as code owners
|
PR too large: 962 lines added (limit: 750, excludes Cargo files, tests, docs, examples, and benchmarks). Please split into smaller PRs. Add |
5 tasks
Collaborator
Author
|
|
leseb
force-pushed
the
leseb/store-infra-635
branch
from
7e2b775 to
8872c82
Compare
Wire ResponseStoreRegistry through server reload/watcher pipeline. Eagerly init store in on_request_body for StreamBuffer pre-read, replace init_store with get_or_init_store retry logic, dedup shared constants to responses/mod.rs, and update integration test assertions for the new messages schema. Signed-off-by: Sébastien Han <seb@redhat.com>
The pipeline_persists_rehydrated_messages_when_response_omits_input test depends on the openai_responses_rehydrate filter which lives in the rehydrate PR (praxis-proxy#604). Move it there. Signed-off-by: Sébastien Han <seb@redhat.com>
leseb
force-pushed
the
leseb/store-infra-635
branch
from
8872c82 to
c3a6e2e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ResponseStoreRegistrythrough the server reload/watcher pipeline so hot-reload preserves store stateon_request_bodyforStreamBufferpre-read compatibilityinit_store()withget_or_init_store()retry logicDEFAULT_STORE_NAME,TENANT_METADATA_KEY,DEFAULT_TENANT_ID) toresponses/mod.rsContext
This extracts store infrastructure improvements from #604 (rehydrate filter) into a standalone PR. These changes are prerequisites for the rehydrate filter but independently valuable — they fix store initialization ordering, improve hot-reload support, and prepare shared constants for cross-filter use.
Stacked on #635 (
ResponsesState).Test plan
make lintpassescargo test -p praxis-proxy-filter --features ai-inferencepassesSigned-off-by: Sébastien Han seb@redhat.com