Skip to content

fix(filter): log when max_tool_calls value is not representable as u32#648

Merged
shaneutt merged 1 commit into
praxis-proxy:mainfrom
leseb:leseb/fix-extract-u32-logging
Jun 22, 2026
Merged

fix(filter): log when max_tool_calls value is not representable as u32#648
shaneutt merged 1 commit into
praxis-proxy:mainfrom
leseb:leseb/fix-extract-u32-logging

Conversation

@leseb

@leseb leseb commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • extract_u32 now logs a debug! trace with the field name and raw value when a JSON value is present but not representable as u32 (negative, float, overflow)
  • Prevents silent fallback to unlimited agentic loop iterations on malformed requests

Closes #647

Test plan

  • make lint passes
  • CI green

Signed-off-by: Sébastien Han seb@redhat.com

@leseb leseb requested a review from a team June 22, 2026 14:57
@leseb leseb enabled auto-merge June 22, 2026 14:57
@leseb leseb added this pull request to the merge queue Jun 22, 2026
@shaneutt shaneutt added the area/ai AI and inference filters label Jun 22, 2026
@shaneutt shaneutt moved this to Review in AI Gateway Jun 22, 2026
@shaneutt shaneutt added this to the v0.4.0 milestone Jun 22, 2026
@shaneutt shaneutt removed this pull request from the merge queue due to a manual request Jun 22, 2026
@shaneutt shaneutt merged commit 81a4558 into praxis-proxy:main Jun 22, 2026
16 of 17 checks passed
@github-project-automation github-project-automation Bot moved this from Review to Done in AI Gateway Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ai AI and inference filters

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Fixes for ResponsesState state.rs

3 participants