Skip to content

refactor(core): Removed Arc from sigs where not required#649

Closed
alexsnaps wants to merge 1 commit into
praxis-proxy:mainfrom
alexsnaps:cleanups
Closed

refactor(core): Removed Arc from sigs where not required#649
alexsnaps wants to merge 1 commit into
praxis-proxy:mainfrom
alexsnaps:cleanups

Conversation

@alexsnaps

Copy link
Copy Markdown
Member

Moved the Arc::clone on the call site, as it isn't "optional", spawn_config_watcher needs to hold on to the Arc, from the spawn_watcher call.
otoh, register_protocols doesn't need an Arc at all, "only" requires to borrow the ref to ListenerPipelines.

Makes the code easier to read, as to what the contract on each of those calls are (without needing to dig, potentially deep, into the call tree) wrt ownership & lifetimes. I think that's generally desirable.

There are a few other places where this could be aligned, if this makes sense to all. wdyt @shaneutt @twghu

Signed-off-by: Alex Snaps <alex@wcgw.dev>
@alexsnaps alexsnaps requested a review from a team June 22, 2026 15:08
@alexsnaps alexsnaps requested review from shaneutt and twghu as code owners June 22, 2026 15:08
@alexsnaps

Copy link
Copy Markdown
Member Author

Darn... Sorry, looks like I have a stale main 🤦
Question remains relevant, but not this PR, let me close and see if it even matters still, looks like all is in ServerState now. Sorry about this again...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant