refactor(core): Removed Arc from sigs where not required#649
Closed
alexsnaps wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Alex Snaps <alex@wcgw.dev>
Member
Author
|
Darn... Sorry, looks like I have a stale |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved the
Arc::cloneon the call site, as it isn't "optional",spawn_config_watcherneeds to hold on to theArc, from thespawn_watchercall.otoh,
register_protocolsdoesn't need anArcat all, "only" requires to borrow the ref toListenerPipelines.Makes the code easier to read, as to what the contract on each of those calls are (without needing to dig, potentially deep, into the call tree) wrt ownership & lifetimes. I think that's generally desirable.
There are a few other places where this could be aligned, if this makes sense to all. wdyt @shaneutt @twghu