fixed compatibility issue g++ compiler fastqueue.hh - #13
Open
mproeling wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Prem,
Thanks for making SVINET publicly available, very useful!
Upon building the package with the most recent g++ compiler I got the following error:
fastqueue.hh:49:23: error: 'constexpr' needed for in-class initialization of static data member 'cont double FastQueue::THRESH' of non-integral type [-fpermissive]
49 | static const double THRESH = 0.8;
Probably because I am using the most recent (today) g++ compiler and that changes the const function:
https://en.cppreference.com/w/cpp/language/constexpr
Hence this change so that g++ can build it :).
Many thanks, warm regards,
Mark Patrick Roeling