Conversation
Three functions were defined but never called from main() or anywhere
else:
mute() -- an unused &>/dev/null wrapper.
disable_if_installed() -- also buggy: it looped over "$@" binding
each unit to $unit, then passed "$@" (the
whole list) to 'systemctl list-unit-files',
so the existence check never corresponded to
the unit being disabled. disable_service()
already covers this and is the one actually
used.
auto_start_terminal() -- along with startup-terminal.desktop, its
only consumer.
Verified each name appears exactly once in the file (its own
definition) before removal, and that nothing else references
startup-terminal.desktop. All three are recoverable from history if
wanted.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
🟢 Approval recommended
The changes are limited to removing unreferenced code/assets and do not affect any remaining call paths.
Pull request overview
This PR removes unused autostart and systemd helper code from the setup script, along with its unused .desktop file, reducing maintenance surface without changing executed behavior.
Changes:
- Deleted three unused shell functions from
setup:mute(),disable_if_installed(), andauto_start_terminal(). - Removed the unused autostart entry file
startup-terminal.desktop.
File summaries
| File | Description |
|---|---|
setup |
Removes dead, unreferenced helper functions to simplify the installer script. |
startup-terminal.desktop |
Deletes an unused autostart desktop entry that no longer has any consumer. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three functions were defined but never called from main() or anywhere
else:
mute() -- an unused &>/dev/null wrapper.$unit, then passed "$ @" (the
disable_if_installed() -- also buggy: it looped over "$@" binding
each unit to
whole list) to 'systemctl list-unit-files',
so the existence check never corresponded to
the unit being disabled. disable_service()
already covers this and is the one actually
used.
auto_start_terminal() -- along with startup-terminal.desktop, its
only consumer.
Verified each name appears exactly once in the file (its own
definition) before removal, and that nothing else references
startup-terminal.desktop. All three are recoverable from history if
wanted.
🤖 Generated with Claude Code