Conversation
- Plugin list was stale: it named lightline (replaced by vim-airline) and omitted which-key, neodev, vim-sleuth, gruvbox.nvim, vim-lastplace, undotree and mru. Regenerated from init.lua, and noted lazy.nvim as the plugin manager. - Dropped the unqualified 'intended to be idempotent / safe to run multiple times' claim and replaced it with a section describing the actual failure: setup_tmux clones unconditionally and aborts the run. - Documented that config files are fetched from GitHub rather than taken from the local checkout, which is surprising given the 'inspect and verify, then run' workflow directly above it. - Install URL now says main rather than master. Note the master URL does still work: there is no master branch on the remote (only main and refactor), but raw.githubusercontent.com falls back to the default branch, so it serves identical content. Corrected for accuracy, not because it was broken. - Added ripgrep, fd, kitty and syncthing to the package list. The two caveats documented here are fixed on the idempotent-git-clones and local-file-first branches, and should be dropped when those land. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
🟢 Approval recommended
Changes are documentation-only and align with the current script behavior, with only a small accuracy tweak suggested.
Pull request overview
Updates the project README to reflect the current behavior and contents of the prestobuntu setup script, especially around supported Ubuntu versions, plugin/package lists, and re-run behavior.
Changes:
- Refreshes documented packages and Neovim plugin list (and notes
lazy.nvimas the plugin manager). - Replaces the blanket “idempotent/safe to re-run” claim with a concrete “Re-running” section describing the current failure mode.
- Corrects the install URL to use
mainand clarifies that config files are fetched from GitHub (not the local checkout).
File summaries
| File | Description |
|---|---|
| README.md | Updates installation docs and caveats; refreshes package/plugin lists and re-run behavior notes. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+56
to
+57
| "already exists" error aborts the whole run. Remove | ||
| `~/.config/tmux/plugins` first, or skip that step, until this is fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plugin list was stale: it named lightline (replaced by vim-airline)
and omitted which-key, neodev, vim-sleuth, gruvbox.nvim, vim-lastplace,
undotree and mru. Regenerated from init.lua, and noted lazy.nvim as
the plugin manager.
Dropped the unqualified 'intended to be idempotent / safe to run
multiple times' claim and replaced it with a section describing the
actual failure: setup_tmux clones unconditionally and aborts the run.
Documented that config files are fetched from GitHub rather than
taken from the local checkout, which is surprising given the
'inspect and verify, then run' workflow directly above it.
Install URL now says main rather than master. Note the master URL
does still work: there is no master branch on the remote (only main
and refactor), but raw.githubusercontent.com falls back to the
default branch, so it serves identical content. Corrected for
accuracy, not because it was broken.
Added ripgrep, fd, kitty and syncthing to the package list.
The two caveats documented here are fixed on the idempotent-git-clones
and local-file-first branches, and should be dropped when those land.
🤖 Generated with Claude Code