Skip to content

zsh: point EDITOR at nvim, the editor we actually install - #19

Open
presto8 wants to merge 1 commit into
mainfrom
fix/editor-nvim
Open

presto8 wants to merge 1 commit into
mainfrom
fix/editor-nvim

Conversation

@presto8

@presto8 presto8 commented Aug 28, 2026

Copy link
Copy Markdown
Owner

setup_nvim runs 'remove_package vim' and installs neovim, so $VISUAL
and $EDITOR pointed at a binary that does not exist on a freshly
provisioned machine. That also broke the 'hint: ${EDITOR:-nano} $0'
message the setup script prints when user_config has not been edited.

Update the fasd 'v' alias to match.


🤖 Generated with Claude Code

setup_nvim runs 'remove_package vim' and installs neovim, so $VISUAL
and $EDITOR pointed at a binary that does not exist on a freshly
provisioned machine. That also broke the 'hint: ${EDITOR:-nano} $0'
message the setup script prints when user_config has not been edited.

Update the fasd 'v' alias to match.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The changes are minimal, consistent with the stated provisioning behavior, and remove references to a non-existent default editor binary.

Pull request overview

This PR aligns shell editor defaults and fasd’s editor alias with the editor actually installed during provisioning (neovim), preventing $VISUAL/$EDITOR from pointing to a missing vim binary and fixing editor hints that rely on $EDITOR.

Changes:

  • Update $VISUAL from vim to nvim so $EDITOR resolves to an installed binary.
  • Update the fasd v alias to open with nvim instead of vim.
File summaries
File Description
prestobuntu.zsh Switches editor environment variables and the fasd v alias to use nvim to match provisioning.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants