Conversation
setup_nvim runs 'remove_package vim' and installs neovim, so $VISUAL
and $EDITOR pointed at a binary that does not exist on a freshly
provisioned machine. That also broke the 'hint: ${EDITOR:-nano} $0'
message the setup script prints when user_config has not been edited.
Update the fasd 'v' alias to match.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
🟢 Approval recommended
The changes are minimal, consistent with the stated provisioning behavior, and remove references to a non-existent default editor binary.
Pull request overview
This PR aligns shell editor defaults and fasd’s editor alias with the editor actually installed during provisioning (neovim), preventing $VISUAL/$EDITOR from pointing to a missing vim binary and fixing editor hints that rely on $EDITOR.
Changes:
- Update
$VISUALfromvimtonvimso$EDITORresolves to an installed binary. - Update the fasd
valias to open withnviminstead ofvim.
File summaries
| File | Description |
|---|---|
prestobuntu.zsh |
Switches editor environment variables and the fasd v alias to use nvim to match provisioning. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setup_nvim runs 'remove_package vim' and installs neovim, so $VISUAL
and $EDITOR pointed at a binary that does not exist on a freshly
provisioned machine. That also broke the 'hint: ${EDITOR:-nano} $0'
message the setup script prints when user_config has not been edited.
Update the fasd 'v' alias to match.
🤖 Generated with Claude Code