Conversation
install_package fd-find installs /usr/bin/fdfind, so nothing named 'fd' ever appeared on PATH -- the README advertises fd but the command did not exist. Link it into ~/.local/bin, which prestobuntu.zsh already prepends to PATH. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
🟡 Changes recommended
The new symlink creation unconditionally overwrites ~/.local/bin/fd, which can clobber a user-provided executable and should be guarded.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR makes the fd command available under its upstream name when installing Debian/Ubuntu’s fd-find package (which ships the binary as fdfind), by symlinking fdfind to ~/.local/bin/fd so it appears on PATH via the existing zsh setup.
Changes:
- Extend
install_fd()insetupto create~/.local/bin/fdpointing to the installedfdfindbinary. - Ensure
~/.local/binexists before creating the symlink.
File summaries
| File | Description |
|---|---|
| setup | Adds a post-install symlink step so fd-find is usable as fd on Debian/Ubuntu. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+339
to
+340
| mkdir -p "$dest" | ||
| ln -sf "$fdfind" "$dest/fd" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
install_package fd-find installs /usr/bin/fdfind, so nothing named 'fd'
ever appeared on PATH -- the README advertises fd but the command did
not exist. Link it into ~/.local/bin, which prestobuntu.zsh already
prepends to PATH.
🤖 Generated with Claude Code