pscripts: test for the script, not the destination directory - #22
Merged
Merged
Conversation
The guard tested '! -f $dest' where $dest is ~/.local/bin, a directory. -f on a directory is always false, so the negation was always true and all three scripts were re-downloaded from GitHub on every run. Also replace the implicit "$_" in the chmod with the explicit path and declare the loop variable local. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
🟢 Approval recommended
The change is a small, targeted correctness fix that prevents repeated downloads and makes the chmod target explicit.
Pull request overview
Fixes the install_pscripts installer guard so it checks for the presence of each script file (rather than the destination directory), preventing unnecessary re-downloads on every run.
Changes:
- Update the existence test to
[[ ! -f "$dest/$script" ]]so scripts are only downloaded when missing. - Replace
chmod a+x "$_"with an explicitchmod a+x "$dest/$script"target. - Declare the loop variable
scriptaslocalwithin the function.
File summaries
| File | Description |
|---|---|
setup |
Corrects install_pscripts to test per-script file existence and applies chmod to the explicit downloaded path. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The guard tested '! -f $dest' where $dest is ~/.local/bin, a directory.
-f on a directory is always false, so the negation was always true and
all three scripts were re-downloaded from GitHub on every run.
Also replace the implicit "$_" in the chmod with the explicit path and
declare the loop variable local.
🤖 Generated with Claude Code