Skip to content

pscripts: test for the script, not the destination directory - #22

Merged
presto8 merged 1 commit into
mainfrom
fix/install-pscripts-guard
Aug 28, 2026
Merged

presto8 merged 1 commit into
mainfrom
fix/install-pscripts-guard

Conversation

@presto8

@presto8 presto8 commented Aug 28, 2026

Copy link
Copy Markdown
Owner

The guard tested '! -f $dest' where $dest is ~/.local/bin, a directory.
-f on a directory is always false, so the negation was always true and
all three scripts were re-downloaded from GitHub on every run.

Also replace the implicit "$_" in the chmod with the explicit path and
declare the loop variable local.


🤖 Generated with Claude Code

The guard tested '! -f $dest' where $dest is ~/.local/bin, a directory.
-f on a directory is always false, so the negation was always true and
all three scripts were re-downloaded from GitHub on every run.

Also replace the implicit "$_" in the chmod with the explicit path and
declare the loop variable local.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is a small, targeted correctness fix that prevents repeated downloads and makes the chmod target explicit.

Pull request overview

Fixes the install_pscripts installer guard so it checks for the presence of each script file (rather than the destination directory), preventing unnecessary re-downloads on every run.

Changes:

  • Update the existence test to [[ ! -f "$dest/$script" ]] so scripts are only downloaded when missing.
  • Replace chmod a+x "$_" with an explicit chmod a+x "$dest/$script" target.
  • Declare the loop variable script as local within the function.
File summaries
File Description
setup Corrects install_pscripts to test per-script file existence and applies chmod to the explicit downloaded path.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@presto8
presto8 merged commit aaa7482 into main Aug 28, 2026
2 checks passed
@presto8
presto8 deleted the fix/install-pscripts-guard branch August 28, 2026 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants