Conversation
setup_nvim ran 'git clone ... lazy.nvim.git --branch=stable' with no
destination argument, so the clone landed in $PWD rather than under
~/.local/share/nvim/lazy. Running the script from a checkout of this
repo left a stray lazy.nvim/ directory in the working tree.
The clone was redundant regardless: init.lua already bootstraps
lazy.nvim into stdpath('data')/lazy/lazy.nvim on first launch.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
🟡 Changes recommended
Dropping the mkdir -p ~/.local/share/nvim/lazy step can cause the init.lua bootstrap git clone to fail when the intermediate lazy/ directory does not exist.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the setup_nvim installer logic to avoid leaving an unintended lazy.nvim/ clone in the caller’s working directory, and instead rely on the existing Neovim config’s lazy.nvim bootstrap behavior.
Changes:
- Removed the
git cloneoffolke/lazy.nvimfromsetup_nvim(previously cloned into$PWDdue to missing destination). - Added an inline note clarifying that lazy.nvim is bootstrapped on first Neovim launch via
init.lua.
File summaries
| File | Description |
|---|---|
| setup | Removes redundant/incorrect lazy.nvim cloning step from setup_nvim. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| local nvimdata="$HOME/.local/share/nvim" | ||
| mkdir -p "$nvimdata"/lazy | ||
| git clone --filter=blob:none https://github.com/folke/lazy.nvim.git --branch=stable | ||
| # lazy.nvim bootstraps itself on first nvim launch; see init.lua |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setup_nvim ran 'git clone ... lazy.nvim.git --branch=stable' with no
destination argument, so the clone landed in $PWD rather than under
~/.local/share/nvim/lazy. Running the script from a checkout of this
repo left a stray lazy.nvim/ directory in the working tree.
The clone was redundant regardless: init.lua already bootstraps
lazy.nvim into stdpath('data')/lazy/lazy.nvim on first launch.
🤖 Generated with Claude Code