ripgrep: install from apt instead of a pinned 2019 .deb - #25
Merged
Merged
Conversation
The 'ripgrep not available via apt install' comment predates Ubuntu 20.04; ripgrep has been in universe since then and this script already refuses to run on anything older than 22.04. The hard-coded 11.0.2 release from 2019 was overwriting whatever the archive provides -- on 24.04 that is 15.1.0 -- and did so on every run, since dpkg -i happily downgrades and re-installs. Also drops a download into a predictable /tmp path. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
🟢 Approval recommended
The change is small, consistent with existing package installation patterns in the script, and eliminates a downgrade-prone pinned .deb install path.
Pull request overview
Updates the Prestobuntu setup script to install ripgrep from Ubuntu’s apt repositories (supported on 22.04+) rather than downloading and installing a pinned 2019 .deb, preventing unintended downgrades and repeated reinstalls.
Changes:
- Replace the hard-coded
ripgrep_11.0.2_amd64.debdownload +dpkg -iflow withinstall_package ripgrep. - Remove use of a predictable
/tmp/ripgrep.debdownload path for this install step.
File summaries
| File | Description |
|---|---|
| setup | Switches install_ripgrep() to use apt via install_package, avoiding pinned external .deb installs and downgrades. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'ripgrep not available via apt install' comment predates Ubuntu
20.04; ripgrep has been in universe since then and this script already
refuses to run on anything older than 22.04. The hard-coded 11.0.2
release from 2019 was overwriting whatever the archive provides -- on
24.04 that is 15.1.0 -- and did so on every run, since dpkg -i happily
downgrades and re-installs.
Also drops a download into a predictable /tmp path.
🤖 Generated with Claude Code