Conversation
Hard-coding TERM=xterm-256color in .zshrc clobbers whatever the
terminal emulator and multiplexer set: kitty exports xterm-kitty and
tmux exports tmux-256color. Overriding both defeats the purpose of
install_kitty_terminfo ("install kitty terminfo so tmux and vim work
correctly") and costs true-colour and undercurl detection in neovim,
which sets termguicolors in init.lua.
TERM is the terminal's responsibility, not the shell's.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
🟢 Approval recommended
The change cleanly removes a problematic environment override and the added comment accurately documents the intended behavior without introducing functional risk.
Pull request overview
Stops prestobuntu.zsh from clobbering the terminal-provided TERM value, which can interfere with correct terminfo selection in terminal emulators (e.g., kitty) and multiplexers (e.g., tmux), and degrade capability detection in terminal apps.
Changes:
- Remove
export TERM=xterm-256colorfrom the zsh RC snippet. - Add an in-file note explaining why
TERMshould not be set from the shell rc and pointing toinstall_kitty_terminfoinsetup.
File summaries
| File | Description |
|---|---|
| prestobuntu.zsh | Removes hard-coded TERM and documents rationale to rely on terminal/tmux-provided TERM. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hard-coding TERM=xterm-256color in .zshrc clobbers whatever the
terminal emulator and multiplexer set: kitty exports xterm-kitty and
tmux exports tmux-256color. Overriding both defeats the purpose of
install_kitty_terminfo ("install kitty terminfo so tmux and vim work
correctly") and costs true-colour and undercurl detection in neovim,
which sets termguicolors in init.lua.
TERM is the terminal's responsibility, not the shell's.
🤖 Generated with Claude Code