Potential fixes for 2 code quality findings#87
Merged
Conversation
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Two improvements to the pre-commit hook: 1. Merge the two 'go test ./...' invocations into one with -race and -coverprofile together. The test suite was running twice on every commit; combining roughly halves hook runtime. -race mandates -covermode=atomic, which the coverage run already used. 2. Treat empty COVERAGE as a failure rather than silently passing. Previously, if 'go tool cover -func' emitted nothing (e.g. the test run above had already aborted), the outer -n guard skipped the threshold check entirely, so a broken coverage profile looked like a clean run.
ethanyzhang
force-pushed
the
ai-findings-autofix/githooks-pre-commit
branch
from
8f04cab to
1fc50e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR applies 2/3 suggestions from code quality AI findings. 1 suggestion was skipped to avoid creating conflicts.