Skip to content

Potential fixes for 3 code quality findings #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ethanyzhang merged 2 commits into from
Apr 13, 2026
Merged

Potential fixes for 3 code quality findings #89

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9946db7
Apply suggested fix to benchmarks/scripts/system_utils.py from Copilo…
ethanyzhang Apr 13, 2026
e491901
Apply suggested fix to benchmarks/scripts/system_utils.py from Copilo…
ethanyzhang Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions benchmarks/scripts/system_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,16 +8,22 @@ def execute_ssh_command(worker_ip, login_user, ssh_key_path, command):
ssh.set_missing_host_key_policy(paramiko.AutoAddPolicy())
private_key = paramiko.Ed25519Key(filename=ssh_key_path)

ssh.connect(hostname=worker_ip, username=login_user, pkey=private_key)
ssh.connect(hostname=worker_ip, username=login_user, pkey=private_key, timeout=30)

stdin, stdout, stderr = ssh.exec_command(command)
stdout_output = stdout.read().decode()
stderr_output = stderr.read().decode()

if stderr_output:
print(f'Error on {worker_ip}: {stderr_output}')
exit_status = stdout.channel.recv_exit_status()
if exit_status != 0:
if stderr_output:
print(f'Error on {worker_ip} (exit status {exit_status}): {stderr_output}')
else:
print(f'Error on {worker_ip}: command exited with status {exit_status}')
sys.exit(1)
else:
if stderr_output:
print(f'Command on {worker_ip} completed with warnings: {stderr_output}')
print(f'Successfully finished running command on {worker_ip}')
return stdout_output
except paramiko.SSHException as ssh_err:
Expand Down
Loading