Fix coverage threshold bug and harden benchmark scripts configurability and security#90
Draft
Copilot wants to merge 2 commits into
Draft
Fix coverage threshold bug and harden benchmark scripts configurability and security#90Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
…ging module, and harden SSH in benchmark scripts Agent-Logs-Url: https://github.com/prestodb/pbench/sessions/c90caf7f-fdb0-47b9-ae4d-30eac8b06fb4 Co-authored-by: ethanyzhang <6643318+ethanyzhang@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix inconsistent coverage calculation in pre-commit hook
Fix coverage threshold bug and harden benchmark scripts configurability and security
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several bugs and hardcoded values in the pre-commit hook and benchmark scripts reduced reliability and flexibility. Coverage comparison was broken due to a scaling mismatch, SSH connections were vulnerable to MITM, and key operational parameters were not configurable.
.githooks/pre-commitc * 100vs threshold5000was inconsistent — simplify toprintf "%d", cand compare against50benchmarks/scripts/system_utils.pyAutoAddPolicy()withload_system_host_keys()+RejectPolicy()to prevent MITM attacksEd25519KeywithPKey.from_path()to support RSA, ECDSA, and Ed25519 keys genericallytimeouta parameter (default30)benchmarks/scripts/mysql_utils.pyprintwithlogging.getLogger(__name__)for proper log level controlbenchmarks/scripts/cache_cleaning_workers.pybuild_cache_clean_command()to deduplicate disk/memory cache command construction--container-name-pattern(default^presto_workers) to make Docker filter configurable--sshuser(defaultcentos),--worker-http-port(default8080) as CLI args--cleanup-disk-cache,--cleanup-os-cache,--cleanup-memory-cacheflags; when none specified, all three run (preserving existing behavior)Original prompt