Skip to content

Shade resolver dependency#7

Closed
ShahimSharafudeen wants to merge 1 commit into
prestodb:masterfrom
ShahimSharafudeen:resolver_fix
Closed

Shade resolver dependency#7
ShahimSharafudeen wants to merge 1 commit into
prestodb:masterfrom
ShahimSharafudeen:resolver_fix

Conversation

@ShahimSharafudeen
Copy link
Copy Markdown

Shaded the resolver dependency to fix code breakage caused by the override of Guice 7.0.0 from the Presto root module.

1) [Guice/ErrorInjectingConstructor]: ExceptionInInitializerError
  at FunctionPluginManager.<init>(FunctionPluginManager.java:85)
  at FunctionServerModule.setup(FunctionServerModule.java:63)
  while locating FunctionPluginManager

Caused by: java.lang.IllegalArgumentException: org.eclipse.sisu.Parameters is not a binding annotation. Please annotate it with @BindingAnnotation.
	at com.google.common.base.Preconditions.checkArgument(Preconditions.java:218)
	at com.google.inject.Key.ensureIsBindingAnnotation(Key.java:382)
	at com.google.inject.Key.strategyFor(Key.java:370)
	at com.google.inject.Key.get(Key.java:229)
	at org.eclipse.sisu.wire.ParameterKeys.<clinit>(ParameterKeys.java:28)

Testing:
All the original unit tests are passing.

image image image

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Jun 25, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: ShahimSharafudeen / name: Shahim Sharafudeen (a2080f6)

@ShahimSharafudeen ShahimSharafudeen marked this pull request as draft June 25, 2025 11:29
@ShahimSharafudeen ShahimSharafudeen marked this pull request as ready for review June 25, 2025 11:29
Copy link
Copy Markdown
Member

@imjalpreet imjalpreet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShahimSharafudeen, thank you. Can you also share the final shaded jar structure for verification?

Comment thread resolver/pom.xml Outdated
<properties>
<air.main.basedir>${project.parent.basedir}</air.main.basedir>
<dep.slf4j.version>2.0.16</dep.slf4j.version>
<shadeBase>resolver.shaded</shadeBase>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I think we can keep it as com.facebook.airlift.resolver.\$internal like we do for Presto's other shaded dependencies.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@ShahimSharafudeen
Copy link
Copy Markdown
Author

@ShahimSharafudeen, thank you. Can you also share the final shaded jar structure for verification?

image

@ShahimSharafudeen
Copy link
Copy Markdown
Author

This change is not required now. So closing this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants