Shade resolver dependency#7
Closed
ShahimSharafudeen wants to merge 1 commit into
Closed
Conversation
|
|
9494594 to
bfe1b73
Compare
imjalpreet
reviewed
Jun 26, 2025
Member
imjalpreet
left a comment
There was a problem hiding this comment.
@ShahimSharafudeen, thank you. Can you also share the final shaded jar structure for verification?
| <properties> | ||
| <air.main.basedir>${project.parent.basedir}</air.main.basedir> | ||
| <dep.slf4j.version>2.0.16</dep.slf4j.version> | ||
| <shadeBase>resolver.shaded</shadeBase> |
Member
There was a problem hiding this comment.
nit: I think we can keep it as com.facebook.airlift.resolver.\$internal like we do for Presto's other shaded dependencies.
bfe1b73 to
a2080f6
Compare
Author
|
Author
|
This change is not required now. So closing this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Shaded the resolver dependency to fix code breakage caused by the override of Guice 7.0.0 from the Presto root module.
Testing:
All the original unit tests are passing.