Data reading fixes - #377
Draft
JGuetschow wants to merge 5 commits into
Draft
JGuetschow wants to merge 5 commits into
JGuetschow wants to merge 5 commits into
Conversation
* changed order of numerical code mapping to always map codes including values mappend to nan to nan.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #377 +/- ##
=======================================
Coverage ? 97.30%
=======================================
Files ? 54
Lines ? 5372
Branches ? 0
=======================================
Hits ? 5227
Misses ? 145
Partials ? 0 ☔ View full report in Codecov by Harness. |
Contributor
|
I forgot to check for open PRs before starting with the fixes and upgrades. The test fixes are now already part of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
Do not review or merge yet, I still have to test this thoroughly on actual data to see how much it messes up my data processing.
Please confirm that this pull request has done the following:
{pr}.thing.mdfile in the directorychangelogadded - see changelog/README.md for detailsDescription
Please provide a short description what your pull request does.