Skip to content

Data reading fixes - #377

Draft
JGuetschow wants to merge 5 commits into
mainfrom
data_reading_fixes_2025
Draft

JGuetschow wants to merge 5 commits into
mainfrom
data_reading_fixes_2025

Conversation

@JGuetschow

Copy link
Copy Markdown
Contributor

Pull request

  • A few changes in string processing.
  • Some failing tests fixed

Do not review or merge yet, I still have to test this thoroughly on actual data to see how much it messes up my data processing.

Please confirm that this pull request has done the following:

  • Tests added
  • Documentation added (where applicable)
  • Description in a {pr}.thing.md file in the directory changelog added - see changelog/README.md for details

Description

Please provide a short description what your pull request does.

  • A few changes in string processing. Most importantly the order of mapping to 0 and NaN has changed for string containing multiple string codes. The reason ist that this is mostly used for higher level sectors where the list of codes is just the list of all codes in the subsectors. In this case it makes more sense to have NaN for the higher level sector if at least one of the subsectors is NaN instead of zero if at least one of the subsectors is zero.
  • Some tests for the gaps functions in the csg were failing because the default time format has changed (us instead of ns). They have been fixed

* changed order of numerical code mapping to always map codes including values mappend to nan to nan.
@codecov

codecov Bot commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@467b9e9). Learn more about missing BASE report.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #377   +/-   ##
=======================================
  Coverage        ?   97.30%           
=======================================
  Files           ?       54           
  Lines           ?     5372           
  Branches        ?        0           
=======================================
  Hits            ?     5227           
  Misses          ?      145           
  Partials        ?        0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@fuchsi-huber

Copy link
Copy Markdown
Contributor

I forgot to check for open PRs before starting with the fixes and upgrades. The test fixes are now already part of main - do you want the remaining changes from this PR merged as well @JGuetschow ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants