fix(local): resolve Prisma dev through package manifest - #268
fix(local): resolve Prisma dev through package manifest#268AmanVarshney01 wants to merge 1 commit into
Conversation
Signed-off-by: Aman Varshney <amanvarshney.work@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
Included review availability: 1 review is currently available. Your included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour. Summary by CodeRabbit
Walkthrough
Merge Risk: ⚪ Minimal · up to This localized change adjusts Prisma development-module resolution and adds fallback coverage; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
commit: |
|
Closing this for now. I opened it before confirming the upstream PR plan with the team. |
Summary
prisma/package.jsonbefore looking up the CLI-owned@prisma/devprismafixture that has no root export@prisma/devresolution for existing installationsWhy
The local Postgres provider lets the generated application own its Prisma version. It first resolves
@prisma/devdirectly and then falls back to theprismadependency tree. The fallback currently resolves the rootprismaentry, but the consolidated package intentionally has no root export. In strict workspace layouts that means resolution fails even whenprismacorrectly carries@prisma/dev.Resolving
prisma/package.jsonuses an existing exported subpath and givescreateRequirethe correct package boundary. This removes the need for generated templates to depend directly on the internal emulator runtime.Validation
pnpm buildpnpm --filter @internal/local-target test— 15 passedpnpm --filter @internal/local-target typecheckCompanion fix
@prisma/devwith both published Prisma CLI manifests.