-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Close Prisma 7 config project #30026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v7
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| # Drive `code-review` context | ||
|
|
||
| > Read by `drive-code-review` before it starts. Capture project-specific facts the generic skill can't know. Update when a drive run surfaces something the next run should inherit. | ||
|
|
||
| **Skills served:** `drive-code-review` | ||
|
|
||
| ## Review focus areas | ||
|
|
||
| Check Prisma 7 behavior against the repository's current code and accepted project spec rather than historical Prisma assumptions. For config discovery changes, separate runtime c12 behavior from non-executing bootstrap detection and verify the exact supported extension set. | ||
|
|
||
| ## Anti-patterns | ||
|
|
||
| - **2026-08-14 — Review-comment scope substitution:** Do not interpret a review comment from its prose alone and then rewrite the accepted spec to match that interpretation. Inspect the exact commented diff lines, reconcile the request with the active spec, and ask the reviewer when they appear inconsistent. In PR #30020, a comment on newly added legacy JSON/JSONC/JSON5/YAML/YML/TOML candidates was incorrectly applied to the separately required Prisma 7 JavaScript/TypeScript extension family. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win Link the incident-specific guidance to its canonical source. Line 13 contains a dated incident narrative. Line 26 provides only a bare PR reference. Add the canonical PR link and keep the local text focused on the reusable rule. Proposed documentation update- - Incident reference: Prisma PR `#30020`
+ - Incident reference: [Prisma PR `#30020`](https://github.com/prisma/prisma/pull/30020)As per coding guidelines: Also applies to: 26-26 🤖 Prompt for AI AgentsSource: Coding guidelines |
||
|
|
||
| ## Ownership map | ||
|
|
||
| Use package ownership and requested reviewers from the affected Prisma areas; no additional Drive-specific ownership map is maintained. | ||
|
|
||
| ## Known constraints & gaps | ||
|
|
||
| Automated review summaries can describe a larger diff region than the exact human concern. Anchor resolution to the line-level thread and final requested behavior. | ||
|
|
||
| ## References | ||
|
|
||
| - Repository agent guidance: [`AGENTS.md`](../../AGENTS.md) | ||
| - Incident reference: Prisma PR #30020 | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| # Drive `pr` context | ||
|
|
||
| > Read by `drive-pr-description` and `drive-pr-walkthrough` before they start. Capture project-specific facts the generic skills can't know. Update when a drive run surfaces something the next run should inherit. | ||
|
|
||
| **Skills served:** `drive-pr-description`, `drive-pr-walkthrough` | ||
|
|
||
| ## PR template | ||
|
|
||
| Use concise sections for overview, changes, rationale, scope, and verification. Close-out PRs additionally include project-DoD evidence, artifact classification, reference-scan results, and the merged implementation PR. | ||
|
|
||
| ## Labels & metadata | ||
|
|
||
| Target the same base branch as the merged implementation project unless the operator says otherwise. Do not invent Linear references, labels, or milestones. | ||
|
|
||
| ## CI gate context | ||
|
|
||
| Treat required GitHub checks as blocking. Distinguish optional/advisory checks explicitly, and investigate failures against the exact failing test before changing implementation. | ||
|
|
||
| ## Known constraints & gaps | ||
|
|
||
| PR review comments are requirements input, not automatically a replacement for the accepted spec. Reconcile comments with the exact diff hunk and active spec before changing scope. | ||
|
|
||
| ## References | ||
|
|
||
| - Repository agent guidance: [`AGENTS.md`](../../AGENTS.md) |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| # Drive `project` context | ||
|
|
||
| > Read by `drive-create-project` and `drive-close-project` before they start. Capture project-specific facts the generic skills can't know. Update when a drive run surfaces something the next run should inherit. | ||
|
|
||
| **Skills served:** `drive-create-project`, `drive-close-project` | ||
|
|
||
| ## Project tracking | ||
|
|
||
| Transient project workspaces live under `projects/<project>/`. No default Linear team or board is assumed; record tracker references explicitly when supplied. Closed project workspaces are deleted rather than archived in-tree. | ||
|
|
||
| ## Lanes & ownership | ||
|
|
||
| Use the ownership and review requirements of the affected Prisma packages. No separate Drive lane map is maintained. | ||
|
|
||
| ## Acceptance-criteria conventions | ||
|
|
||
| Use binary `AC-<number>` criteria in the project review ledger. At close, retain evidence in the merged implementation PR and its tests; project coordination files remain transient. | ||
|
|
||
| ## Closing conventions | ||
|
|
||
| Require all slice PRs to be merged or explicitly deferred, all review threads resolved, CI complete, and the mandatory final retro landed. Migrate only genuinely reusable methodology; specs, plans, briefs, rollups, reviews, walkthroughs, traces, and retros are transient. Open a dedicated close-out PR that deletes the project workspace. | ||
|
|
||
| ## Known constraints & gaps | ||
|
|
||
| A project may have no Linear reference. In that case, state this explicitly in the close-out PR instead of inventing one. | ||
|
|
||
| ## References | ||
|
|
||
| - Repository agent guidance: [`AGENTS.md`](../../AGENTS.md) |
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wtf are those files?