Error-reference follow-ups: one code per condition, doc sync, legacy retirement - #238
Merged
Merged
Conversation
SERVICE.PROJECT_NOT_FOUND and PROJECT.NOT_FOUND described the same user-facing condition, and which code you got depended on the command you entered through. The service raise site keeps its own message and next actions (project show, project link) but now carries the project group's code, and the registry folds the services-API case into the PROJECT.NOT_FOUND entry. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io>
The list still described the MVP plan: --trace never shipped, and --format, --log-level, --confirm, and --config were missing. The list now mirrors SHARED_FLAG_PARAMETERS in packages/cli-engine/src/execution/shared-flags.ts and names that as the source of truth. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io>
prisma/web's sync-error-reference-docs.yml has listened for this repository_dispatch since it was added, but nothing ever sent it, so the hosted page could lag a registry change by up to a day until the cron fired. A push to main touching docs/reference/error-reference.md now sends the event. Needs the WEB_DISPATCH_TOKEN secret: a token allowed to send repository dispatches to prisma/web. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io>
src/legacy/ held the last types named after the deleted command shell. CliRuntime and CommandContext move to controllers/context.ts, CommandSuccess moves into its only user, controllers/app-env-file.ts, and the unused CliOutput is gone. The legacyOperationContext adapter is now operationContext, and its test file follows the rename. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (18)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. Summary by CodeRabbit
WalkthroughThe PR migrates project commands from the legacy runtime context to the controller operation context. It moves the Merge Risk: ⚪ Minimal · up to The PR updates error references, documentation, synchronization, and legacy naming without a remaining actionable merge-blocking risk; it is merge-ready after normal checks and review. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 9.09% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 11 functions across 14 files. (3 skipped: 3 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups to #234, per the operator's brief.
One code for a missing project.
SERVICE.PROJECT_NOT_FOUNDandPROJECT.NOT_FOUNDdescribed the same user-facing condition; which one you got depended on the command you entered through. The service raise site now carriesPROJECT.NOT_FOUND, keeping its own message and next actions (project show,project link), and the registry folds the services-API case into thePROJECT.NOT_FOUNDentry. 125 codes now.Style guide flag list synced. The "Shared global flags for the MVP" list still described the plan:
--tracenever shipped, and--format,--log-level,--confirm, and--configwere missing. The list now mirrorsSHARED_FLAG_PARAMETERSand names it as the source of truth.Event-driven docs sync. prisma/web has listened for the
error-reference-updatedrepository_dispatch since the sync workflow was added, but nothing ever sent it, so the hosted page lagged registry changes by up to a day. A push to main touchingdocs/reference/error-reference.mdnow sends the event. Needs theWEB_DISPATCH_TOKENrepo secret — a token allowed to send repository dispatches to prisma/web (fine-grained PAT on prisma/web with Contents read/write, or classicreposcope). Until it exists the job fails harmlessly and the daily cron still covers.src/legacy/retired. The last types named after the deleted command shell move to their users:CliRuntime/CommandContexttocontrollers/context.ts,CommandSuccessintocontrollers/app-env-file.ts; unusedCliOutputdeleted;legacyOperationContextrenamed tooperationContext.Verified:
pnpm check:error-reference(registry and source agree, 125 codes),pnpm typecheck,npx biome check . --error-on-warnings,pnpm --filter @prisma/cli test(960 passed, 1 skipped).🤖 Generated with Claude Code