The engine publishes under latest, by the same rule as every other package - #240
Open
wmadden-electric wants to merge 1 commit into
Open
The engine publishes under latest, by the same rule as every other package#240wmadden-electric wants to merge 1 commit into
wmadden-electric wants to merge 1 commit into
Conversation
…ckage A merged version-bump PR is what publishes a version under latest. The engine's bump merges on an ordinary push, whose publish run only had a dev half — so the engine's first (and only possible) publish went out tagged dev, latest stayed on the previous version, and moving it needed a hand-run npm dist-tag add, which OIDC cannot do. 0.2.x and 0.3.0 all shipped mis-tagged this way. The dev half now publishes the engine's committed version under latest before the dev-stamped CLI packages publish under dev, and verifies it resolves. An already-published engine version stays a no-op, and the engine stays out of the dev channel entirely: its line carries no pre-releases (ADR 0004), so every engine publish is a release. Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io>
|
Warning Review limit reachedNext included review available in 26 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
wmadden
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A merged version-bump PR publishes that version under
latest— that is the rule forprismaand@prisma/cli, and the engine was the exception: its bump merges on an ordinary push, whose publish run only had a dev half, so every new engine version (0.2.x, 0.3.0) reached the registry taggeddevwhilelateststayed stuck on the previous version until an operator hand-rannpm dist-tag add(which OIDC cannot do for the workflow).This makes the engine follow the same rule, applied at its own version bump: the dev half publishes the engine's committed manifest version under
latest(first — the CLI depends on it), then the dev-stamped@prisma/cliandprismapublish underdev, and the verify step now covers the engine too. An already-published engine version remains a no-op, and the engine stays out of the dev channel entirely — its line carries no pre-releases (ADR 0004), so every engine publish is a release and its first publish is the one moment OIDC can set the tag.docs/oss/versioning.mdis updated to state the rule and record the pre-2026-08-26 mis-tagging.Not covered:
@prisma/cli-engine@0.3.0is already published, so this cannot retro-tag it — one final handnpm dist-tag add @prisma/cli-engine@0.3.0 latestis still owed.Verified:
pnpm lint,pnpm test:scripts.🤖 Generated with Claude Code