Open
Conversation
Collaborator
|
Seems good. I've just got married and we're chillouting in Italy so I'll take a look next week :) |
Codecov Report
@@ Coverage Diff @@
## master #55 +/- ##
==========================================
- Coverage 87.44% 87.33% -0.12%
==========================================
Files 61 66 +5
Lines 1107 1192 +85
Branches 194 207 +13
==========================================
+ Hits 968 1041 +73
- Misses 138 150 +12
Partials 1 1
Continue to review full report at Codecov.
|
Paiza28
approved these changes
Feb 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11
Hey there. First off, great package. I'm really enjoying it.
I was hoping this PR would be a great jumping off point for interfaces.
Using
extendvery nicely adds functionality to classes. Therefore, it seemed natural to allow an InterfaceType to be implemented on an ObjectType viaextend.As for allowing Types to implement multiple interfaces, I was thinking this new
InterfaceTypeclass could be leveraged somehow via new helper like the following:If you are open to it, I'd be happy to "implement
@Implements" in a separate PR.