Skip to content

fix: handle already finalized container in rollout process #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
frankmer wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: handle already finalized container in rollout process #504

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/utils/riverpod/riverpod_providers/generated_providers/token_container_notifier.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,7 +649,12 @@ class TokenContainerNotifier extends _$TokenContainerNotifier
await _finalizationMutex.acquire();
if (container is! TokenContainerUnfinalized) {
_finalizationMutex.release();
throw ArgumentError('Container must not be finalized');
if (container is TokenContainerFinalized) {
Logger.info('Container is already finalized, skipping rollout: ${container.serial}');
return container;
}
Logger.error('Unexpected container type for rollout: ${container.runtimeType}');
return null;
}
urlIsOk ??=
((await ContainerShowContainerUrlDialog.showDialog(container)) == true);
Expand Down
Loading