Skip to content

Stop the secret scan failing on commit counts that end in zero #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kwsantiago merged 2 commits into from
Oct 21, 2026
Merged

Stop the secret scan failing on commit counts that end in zero #5

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da3d4a1
Stop the secret scan failing on commit counts that end in zero
kwsantiago Oct 20, 2026
9ddb689
Require exactly one commit count above zero from the secret scan
kwsantiago Oct 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/security-scans.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,12 @@ jobs:
# so a broken mount or an ownership problem would report a clean scan over a
# repo full of secrets. Both failure signatures are checked: nothing walked,
# and git having written to stderr at all.
if printf '%s' "$log" | grep -q '0 commits scanned'; then
echo "::error::gitleaks scanned 0 commits, so the scan did not run"
# Require exactly one count, and fail unless it is provably above zero. A
# substring match on "0 commits scanned" also matched 10 and 1600; a
# missing, repeated, zero or non-numeric count all fail closed here.
scanned=$(printf '%s' "$log" | grep -oE '[0-9]+ commits scanned' | grep -oE '^[0-9]+' || true)
if [ "$(printf '%s\n' "$scanned" | grep -c .)" -ne 1 ] || ! [ "$scanned" -gt 0 ] 2>/dev/null; then
echo "::error::gitleaks did not report one commit count above zero, so the scan did not run"
exit 1
fi
if printf '%s' "$log" | grep -q '\[git\]'; then
Expand Down
Loading