Repository navigation
Patch ctutils and drop crypto-bigint 0.6 for two constant-time advisories - #1115
Merged
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 36 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cargo deny: RUSTSEC-2026-0385 (ctutils non-constant-time masks) and RUSTSEC-2026-0387 (crypto-bigint timing variability, fixed only in 0.7.6).stdandzeroize. Itsbigintfeature was the only thing that built crypto-bigint 0.6.1, which keep never called; the Shamir split and combine run on k256 types either way, and keep serializes shares itself, so the droppedserdeandprimitivefeatures were unused. 0.6.1 still appears in Cargo.lock through vsss-rs weak features but is not compiled, so lockfile-only scanners may still list it.deny.toml. k256 0.13 calls it on secrets only for its mask-based modular add, subtract, negate and comparisons; scalar multiplication, inversion and field arithmetic are k256's own code, and 0.5.5 contains none of the advisory'sUintRef,BoxedMontyFormor ctutils code.[bans]entries refuse crypto-bigint 0.6 and 0.7 below 0.7.6, pre-releases included, so the ignore cannot hide a returning unpatched line.Test plan
cargo deny checkpasses for the root workspace and both agent bindingscargo tree -i crypto-bigint@0.6.1is empty (crate not compiled)oprf, keep-frost-net OPRF tests, enclave workspace testscargo clippy --workspace --all-targetswith the CI feature set, warnings denied