Skip to content

Update noscrypt fork to upstream v0.1.15 - #73

Merged
kwsantiago merged 1 commit into
mainfrom
noscrypt-v0.1.15
Oct 5, 2026
Merged

kwsantiago merged 1 commit into
mainfrom
noscrypt-v0.1.15

Conversation

@kwsantiago

@kwsantiago kwsantiago commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Merges upstream noscrypt v0.1.15 into the privkeyio/noscrypt esp-idf-support branch and repins the ESP-IDF job to it. The fork was based on v0.1.13 and missed libsecp256k1 0.7.1, mbedTLS 3.6.6, the span bounds-check rework, and the fixed-time fallback fix. Linux and macOS already build against v0.1.15.

Also replaces the now-deprecated NC_PUBKEY_SIZE with NOSTR_PUBKEY_SIZE, matching the surrounding copies.

Verified locally: host build with noscrypt enabled has no warnings and passes 15/15 tests; ESP-IDF v5.4.1 esp32s3 build and QEMU smoke test report SMOKE-PASS.

Summary by CodeRabbit

  • Bug Fixes
    • Corrected public-key byte handling for event verification, key exchange and validation, and NIP-44 encryption and decryption when using the noscrypt backend. These operations now use the expected key size, improving reliability.

@coderabbitai

coderabbitai Bot commented Oct 5, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 469b049e-d177-4dba-b4d6-df3e170610b7
📥 Commits

Reviewing files that changed from the base of the PR and between 361a491 and b0a1a8f.

📒 Files selected for processing (4)
  • .github/workflows/build.yml
  • src/event.c
  • src/key.c
  • src/nip44.c
 ____________________________
< Copilot has nothing on me. >
 ----------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kwsantiago
kwsantiago merged commit bed17a4 into main Oct 5, 2026
12 of 13 checks passed
@kwsantiago
kwsantiago deleted the noscrypt-v0.1.15 branch October 5, 2026 03:08
@kwsantiago kwsantiago mentioned this pull request Oct 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant