Repository navigation
Update noscrypt fork to upstream v0.1.15 - #73
Merged
Merged
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (4)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges upstream noscrypt v0.1.15 into the
privkeyio/noscryptesp-idf-supportbranch and repins the ESP-IDF job to it. The fork was based on v0.1.13 and missed libsecp256k1 0.7.1, mbedTLS 3.6.6, the span bounds-check rework, and the fixed-time fallback fix. Linux and macOS already build against v0.1.15.Also replaces the now-deprecated
NC_PUBKEY_SIZEwithNOSTR_PUBKEY_SIZE, matching the surrounding copies.Verified locally: host build with noscrypt enabled has no warnings and passes 15/15 tests; ESP-IDF v5.4.1 esp32s3 build and QEMU smoke test report SMOKE-PASS.
Summary by CodeRabbit