Skip to content

Build with Zig 0.17 as well as 0.16 - #148

Merged
kwsantiago merged 2 commits into
mainfrom
zig-0.17
Oct 6, 2026
Merged

kwsantiago merged 2 commits into
mainfrom
zig-0.17

Conversation

@kwsantiago

Copy link
Copy Markdown
Contributor

Zig 0.17.0 removes @cImport and array repetition (**), and changes std.meta.declarations to return names. This builds and passes the full suite on both 0.16.0 and 0.17.0:

  • C headers go through b.addTranslateC modules (noscrypt_c from src/noscrypt_c.h, openssl_c from src/openssl_c.h) imported by the library and test modules.
  • ** becomes @splat; std.ascii.indexOfIgnoreCase becomes findIgnoreCase; the enum round-trip tests use std.enums.values.
  • The test-only refAllDeclsRecursive reads declaration names for either compiler (the one version check, to drop with 0.16 support).

Dependency pins are unchanged: noscrypt and StringZilla v4.5.1 build under 0.17 with the same hashes. StringZilla 5.x is not adopted here: it changes the layout of the SHA-256 state struct that src/stringzilla.zig mirrors, so it needs its own change. CI now runs Linux and macOS against both compiler versions.

@coderabbitai

coderabbitai Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 10 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5ecddf0f-326f-47db-b76b-a3ecaa859e82
📥 Commits

Reviewing files that changed from the base of the PR and between 30f5687 and d76796b.

📒 Files selected for processing (21)
  • .github/workflows/ci.yml
  • CHANGELOG.md
  • README.md
  • build.zig
  • src/crypto.zig
  • src/negentropy.zig
  • src/nip04.zig
  • src/nip06.zig
  • src/nip46.zig
  • src/nip59.zig
  • src/noscrypt_c.h
  • src/nwc.zig
  • src/openssl_c.h
  • src/pool.zig
  • src/pow.zig
  • src/root.zig
  • src/signer.zig
  • src/ws/frame.zig
  • src/ws/handshake.zig
  • src/ws/ssl.zig
  • src/ws/stream.zig
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kwsantiago
kwsantiago merged commit 9cd91ba into main Oct 6, 2026
5 checks passed
@kwsantiago
kwsantiago deleted the zig-0.17 branch October 6, 2026 05:01
@kwsantiago kwsantiago mentioned this pull request Oct 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant